Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorials and Examples #39

Closed
3 of 5 tasks
lgvaz opened this issue May 30, 2020 · 11 comments
Closed
3 of 5 tasks

Tutorials and Examples #39

lgvaz opened this issue May 30, 2020 · 11 comments
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@lgvaz
Copy link
Collaborator

lgvaz commented May 30, 2020

馃搾 Tutorials

Tutorials are in .ipynb format, explaining each step of the process, really detailed, not production like.

Core

Object detection

Segmentation

Keypoints

馃摀 Examples

Examples are be in the .py format, more production oriented. Ready to be run with arguments from the command line and easy to integrate with wandb sweeps and alike.

Object detection

Segmentation

Keypoints


Is there a new tutorial or example you would like to add? Comment below and we talk about it 馃榿

Once we agree, create an Tutorial or Example request issue (use the template) and I'll edit this post with your new cool example!

@lgvaz lgvaz added documentation Improvements or additions to documentation help wanted Extra attention is needed labels May 30, 2020
@lgvaz lgvaz pinned this issue May 30, 2020
@lgvaz lgvaz added the good first issue Good for newcomers label May 30, 2020
@lgvaz
Copy link
Collaborator Author

lgvaz commented May 30, 2020

It would be a cool addition to show how to do a wandb sweep in the wheat example

@chho-work
Copy link

chho-work commented Jun 1, 2020

Certainly it would be! Wandb supports Pytorch Lightning: https://docs.wandb.com/library/frameworks/pytorch/lightning

I will work on few examples!

@lgvaz lgvaz changed the title Usage examples Examples Jun 5, 2020
@lgvaz
Copy link
Collaborator Author

lgvaz commented Jun 6, 2020

It might be a good idea to separate this into Examples and Tutorials.

Tutorials would be in .ipynb format, explaining each step of the process, really detailed, not production like.

Examples would be in the .py format, more production oriented. Ready to be run with arguments from the command line and easy to integrate with wandb sweeps and alike.

What do you think @chho-work ?

@chho-work
Copy link

Yes, it would be great to have both available, examples and tutorials, each with their corresponding formats.

@lgvaz lgvaz changed the title Examples Tutorials and Examples Jun 9, 2020
@chho-work
Copy link

I found this pretty interesting! I think we can use them in tutorials and examples.
https://github.com/mseg-dataset/mseg-api

@tazu786
Copy link

tazu786 commented Jun 19, 2020

Hi, I have question regarding the new colab on detr fine tuning. Right after loading the checkpoint with no head, shouldn't I freeze all the other layers with something like:

for param in model_without_ddp.parameters():
param.requires_grad = False
model.class_embed.weight.requires_grad = True
model.class_embed.bias.requires_grad = True

Thanks

@lgvaz
Copy link
Collaborator Author

lgvaz commented Jun 19, 2020

That's something we could do as well correct, we actually have an issue for that in #72

@lgvaz
Copy link
Collaborator Author

lgvaz commented Jun 27, 2020

We should change the definitions of tutorials and examples.

Tutorials should be non-repetitive, and should all show in the documentation. Having too many tutorials might confuse beginners! Tutorials should be maintained and created by the core team.

Examples should be a mix of core/community, the can be scripts or notebooks and don't need to explain library concepts. There is no limit to the number of examples we should have, the more the better!

Examples also go very well together with datasets implementations in hub. Maybe all examples should actually be all inside hub? This would make them always self-contained (all functions for downloading data, creating parsers, etc would be present)

@ai-fast-track what do you think?

@ruffson
Copy link

ruffson commented Apr 27, 2021

I don't know if this is the best place to raise this, but I find it quite confusing that the getting started tutorial instructs the user to install everything "by hand" with a shell script which is not what you usually want to do.

So when I installed everything properly and cleanly in a conda env via the install page I came back to do the getting started tutorial but then was missing IceData.

I think it is nice to have a page that just enables you to install and run everything to test things out. But on the other hand there should also be a path to follow a getting started guide right after installing everything completely.

So IMO the object detection needs to refer to the installation instructions (like the image segmentation does already). And additionally the installation instructions need to contain instructions to install icedata.

@lgvaz
Copy link
Collaborator Author

lgvaz commented Apr 27, 2021

So IMO the object detection needs to refer to the installation instructions (like the image segmentation does already). And additionally the installation instructions need to contain instructions to install icedata.

Totally agree on both points! We should do that

@ruffson Would you like to make the changes and submit a PR?

@ruffson
Copy link

ruffson commented Apr 28, 2021

So IMO the object detection needs to refer to the installation instructions (like the image segmentation does already). And additionally the installation instructions need to contain instructions to install icedata.

Totally agree on both points! We should do that

@ruffson Would you like to make the changes and submit a PR?

Sure, I'll do that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants