-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
onBrushEnd infinite render loop #1819
Comments
Hi @balbany, this seems fixed now. Can see it working here on my fork of the example here: https://codesandbox.io/p/sandbox/vigilant-edison-p9pzjv?file=%2FExample.tsx%3A215%2C1-216%2C1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Looks like
@visx/brush
has an infinite render loop bug (when used withuseWindowMoveEvents
).To reproduce:
onBrushChange
handler to be triggered byonBrushEnd
.Sounds similar to #1283 (due to the involvement of
useWindowMoveEvents
).Thanks 🙏
The text was updated successfully, but these errors were encountered: