Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow simultaneous time stretch and work area with precomps #257

Open
marianpavel opened this issue Apr 19, 2017 · 11 comments
Open

Allow simultaneous time stretch and work area with precomps #257

marianpavel opened this issue Apr 19, 2017 · 11 comments

Comments

@marianpavel
Copy link

Hi,

I've requested to the designers of a project to use the Lottie library and get me the JSON file of the animation.
I have received two files, a JSON, and an HTML web page. As you guessed opening the web page shows me the animation but when I import it in android using Lottie or test it on sample application from this repo the animation is not played at all.

I asked the designers for the after effects source but I think it will take some time to receive it and I tough I can find a solution till then.

Below you have the JSON file attached and the web page. Hopefully, I can get some help.
reserve_animation.zip

Best,
Marian

@gpeal
Copy link
Collaborator

gpeal commented Apr 19, 2017

It definitely looks like something isn't rendering correctly. As soon as you attach the AE file, I can take a look

@marianpavel
Copy link
Author

Thank you @gpeal , I have attached the after effects source file.
Thank you !
source.zip

@shashankpsingh
Copy link

The same is in my case too. My animation consists of images and text animation but only image animation work. I am not able to view an animation which consists of text part.
Any update on this issue.

@marianpavel
Copy link
Author

I have asked the design team to redo the animation with the most basic components. After few tryes, the animation works like a charm.

@gpeal
Copy link
Collaborator

gpeal commented May 22, 2017

@shashank26ashu Lottie doesn't yet support text

@charleston10
Copy link

charleston10 commented May 31, 2017

#287

@gpeal
Copy link
Collaborator

gpeal commented Jul 3, 2017

@marianpavel I've just added support for time stretching and work area. However, you can't use the two together yet. If you can create your animation without using both at the same time, it should work now.

@gpeal
Copy link
Collaborator

gpeal commented Jul 3, 2017

I'll release 2.1 or 2.5 this week with the changes

@gpeal gpeal changed the title Animation not showing all the frames Allow simultaneous time stretch and work area Jul 3, 2017
@zmax91
Copy link

zmax91 commented Aug 7, 2017

@gpeal time stretching is not working properly on 2.1 version for me. The animation blinks and stops before reaching the end. Can you please have a look at my .json or .aep files?

@gpeal
Copy link
Collaborator

gpeal commented Feb 21, 2022

@zmax91 Please attach them to a comment here.

@gpeal
Copy link
Collaborator

gpeal commented Mar 4, 2024

I've spent quite a lot of time on this recently. The root cause is when there is a precomp that has time stretch inside of a composition with a work area that starts after 0.

The root cause is, unfortunately, very tricky to solve. Most of the Lottie internal components have access to their own info + the root composition. However, in a situation like this, the progress gets shifted by the root composition's start offset before it gets passed into the precomp. However, the precomp animations need to be able to handle when their own composition has a start offset but because it's pointing at the same root composition, it applies the start offset again which causes all of its progress calculations to be wrong.

Fixing this will require a fairly significant rework of how data is piped around to make it more hierarchical but there are a number of complexities around getting that right.

In the meantime, I've attached a repro AE project that is a minimal repro.

Time Stretch Work Area.aep.zip

@gpeal gpeal changed the title Allow simultaneous time stretch and work area Allow simultaneous time stretch and work area with precomps Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants
@gpeal @charleston10 @marianpavel @shashankpsingh @zmax91 and others