Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git check works only for last commit #7

Open
DanielChabrowski opened this issue Jan 4, 2018 · 1 comment
Open

Git check works only for last commit #7

DanielChabrowski opened this issue Jan 4, 2018 · 1 comment

Comments

@DanielChabrowski
Copy link

Hey,
git diff --check HEAD^ will not work on all commits from PR rendering using it on CI kinda useless.

I don't think there is a way to make it fully generic using git diff unless you make some assumptions like that PRs are always targeting certain branch, but if there is, I would love to know about it.

@rianquinn
Copy link
Collaborator

So far we haven't had any real issues, and we use this code pretty heavily on the following project:
https://github.com/Bareflank/hypervisor/blob/dev/scripts/util/bareflank_clang_tidy.sh#L74

The line is a little different as we did fix an issue with deleted files, something we should fix in this repo as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants