Skip to content
This repository has been archived by the owner on Apr 16, 2021. It is now read-only.

Feature Request: Tag Picker #19

Open
sureshjoshi opened this issue Jun 30, 2018 · 4 comments
Open

Feature Request: Tag Picker #19

sureshjoshi opened this issue Jun 30, 2018 · 4 comments

Comments

@sureshjoshi
Copy link
Contributor

Not sure if there is interest for this - but I'm looking into porting the Office UI Fabric repo's tag picker (currently using vue-select/vue-multiselect).

https://developer.microsoft.com/en-us/fabric#/components/pickers

I'm not sure if you want to keep this repo in lockstep with the baseline office-fabric-js - or if you're interested in a PR (someday) for the Fabric components

@aidewoode
Copy link
Owner

aidewoode commented Jul 2, 2018

Yeah, I plan to rewrite the whole repo just use the office-ui-fabric-core like office-ui-fabric-react.

You know it's lots of works. I don't have so such time for it, the progress will be slow, I plan to rewrite the component one by one base on office-ui-fabric-react. If you have interest, PR are always welcome.

@sureshjoshi
Copy link
Contributor Author

I'm also investigating Vue binding for React:

https://github.com/alkin/vue-react

https://github.com/akxcv/vuera

No success so far, but it might be more maintainable since the react office repo is maintained well and documented (at the expense of maybe a larger codebase? Maybe?)

@aidewoode
Copy link
Owner

I think wrap react component to vue component maybe not a good idea. Because of the performance issues.

@sureshjoshi
Copy link
Contributor Author

I agree that it's not a good long term strategy because of total library size, and maybe performance issues (I assume there will be some hit, but there aren't any metrics anywhere).

It would be a good middle-ground workaround while porting in components though - provides the Vue API to line up with the React one, and then progressively carve out the internals to be Vue only.. Or maybe stick it in a contrib repo?

I still need to get something to compile correctly with Typescript first, then we'll see :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants