Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default app when NOT cmd-clicked #46

Open
lukemt opened this issue Aug 29, 2023 · 1 comment
Open

Default app when NOT cmd-clicked #46

lukemt opened this issue Aug 29, 2023 · 1 comment

Comments

@lukemt
Copy link
Contributor

lukemt commented Aug 29, 2023

I am thinking of removing/ inverting #18 in the following way:

  • instead of attaching event listeners one could differentiate by whether an empty tab has been prepared
  • this is the case when "open in new tab" or cmd-clicked a link
  • in such a case we could even say we do not want to open with the default app which would precisely invert Add option to open with default app only on cmd+click #18 but I think it would make sense and probably increases the overall stability

What do you guys think?

Probably nothing since I'm mostly doing self talk here but if anyone does have an opinion on this one, feel free to share here

@LordLioath
Copy link

Probably just leave it as an option, I prefer it to be ctrl / cmd click to open in external app, though that seems bugged atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants