Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Run triggers are outdated #144

Open
gjermundgaraba opened this issue Jun 18, 2021 · 2 comments
Open

Cloud Run triggers are outdated #144

gjermundgaraba opened this issue Jun 18, 2021 · 2 comments

Comments

@gjermundgaraba
Copy link

"Cloud Run can only receive HTTP requests or Pub/Sub push events."

This is not true anymore. Cloud Run can now accept events via WebSockets, Eventarc (which let's Cloud Run react to something akin to CloudEvents, but more specifically events from over 90 GCP services - making the distinction between Cloud Functions and Cloud Run less obvious), as well as invocations by gRPC.

https://cloud.google.com/run/docs/triggering/grpc
https://cloud.google.com/eventarc/docs/overview

@ahmetb
Copy link
Owner

ahmetb commented Jun 18, 2021

WebSockets or gRPC are still HTTP requests.

Similarly, Eventarc also delivers over HTTP (in cloudevents format).

So I think the only revision needed is to add Eventarc next to Pub/Sub.

@gjermundgaraba
Copy link
Author

gjermundgaraba commented Jun 18, 2021

That was not really the point. And if you want to be specific about it: Only the initial opening of the websocket connection is http, everything after is not. And just because it can receive those things over HTTP doesn't mean it supports any protocol over HTTP. Cloud Functions also use HTTP, but they don't support gRPC or websocket.

The point is that the section in question is about the differences between Cloud Run and Cloud Functions. So perhaps a better way of phrasing this is to specify the different trigger types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants