From f7ad1820afb4b37ba26cfdf96811e94e071cc731 Mon Sep 17 00:00:00 2001 From: AH-dark Date: Sun, 7 Jan 2024 11:59:50 +0800 Subject: [PATCH] feat: added sampling rate configuration --- cmd/generator/main.go | 6 +----- common/observability/trace.go | 7 +++++-- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/cmd/generator/main.go b/cmd/generator/main.go index 2be714d..88e8dac 100644 --- a/cmd/generator/main.go +++ b/cmd/generator/main.go @@ -4,10 +4,10 @@ import ( "context" "flag" "fmt" + "github.com/AH-dark/bytestring" md5simd "github.com/minio/md5-simd" "github.com/uptrace/opentelemetry-go-extra/otelzap" - "go.opentelemetry.io/otel" "go.uber.org/fx" "go.uber.org/zap" @@ -17,7 +17,6 @@ import ( ) var ctx = context.Background() -var tracer = otel.Tracer("github.com/AH-dark/gravatar-with-qq-avatar/cmd/generator") var ( from = int64(10000) @@ -31,9 +30,6 @@ func init() { } func generate(ctx context.Context, md5QQMappingRepo dal.MD5QQMappingRepo) error { - ctx, span := tracer.Start(ctx, "cmd.generator.generate") - defer span.End() - svr := md5simd.NewServer() defer svr.Close() diff --git a/common/observability/trace.go b/common/observability/trace.go index 5242846..ed489e2 100644 --- a/common/observability/trace.go +++ b/common/observability/trace.go @@ -74,7 +74,7 @@ func NewTraceProvider( ctx, span := tracer.Start(ctx, "observability.NewTraceProvider") defer span.End() - tp := tracesdk.NewTracerProvider( + opts := []tracesdk.TracerProviderOption{ tracesdk.WithResource(resource), tracesdk.WithBatcher( exporter, @@ -83,7 +83,10 @@ func NewTraceProvider( tracesdk.WithExportTimeout(vip.GetDuration("observability.trace.export_timeout")), tracesdk.WithMaxQueueSize(vip.GetInt("observability.trace.max_queue_size")), ), - ) + tracesdk.WithSampler(tracesdk.TraceIDRatioBased(vip.GetFloat64("observability.trace.sampling_rate"))), + } + + tp := tracesdk.NewTracerProvider(opts...) lc.Append(fx.Hook{ OnStop: func(ctx context.Context) error {