Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add navigation element #4

Open
agauniyal opened this issue May 17, 2016 · 13 comments
Open

add navigation element #4

agauniyal opened this issue May 17, 2016 · 13 comments

Comments

@agauniyal
Copy link
Owner

using nav tag, create styles for horizontal/vertical navigation elements. should goto _base.scss and might add some to _misc.scss.

@mnpal
Copy link

mnpal commented Oct 29, 2016

Hello, I'm a new contributor.
Do I need to just make changes in the _base.scss and _misc.scss files? Or after making the changes do I need to create a link to the main.html file too for these two files?
thanks!

@ryuhhnn
Copy link
Collaborator

ryuhhnn commented Oct 30, 2016

You may set up a new partial for nav elements if you'd like under _nav.scss, just be sure to import it

@agauniyal
Copy link
Owner Author

As @ryuhhnn suggested, _nav.scss file would be better for these changes, just make sure to make the PR against develop branch. And you don't need to link those two files manually in main.html, that is automatically done by gulp.

@iishasmall
Copy link

i'd like to help

@agauniyal
Copy link
Owner Author

Sure @iishasmall go ahead and open up a PR 👍

@benAsiri
Copy link

@iishasmall Hey I choose this Project to Contribute on OpensorceFriday.

@agauniyal agauniyal added this to the 1.0.0 milestone Jul 24, 2017
@wilsotobianco
Copy link

Hey guys, are you still waiting for this to be done?

@agauniyal
Copy link
Owner Author

@wilsotobianco you can take look at develop branch for contributing :)

@wilsotobianco
Copy link

Awesome man. Can you describe the issue a little bit better?

@agauniyal
Copy link
Owner Author

Sure. You can make changes either in style files located here - https://github.com/agauniyal/wireframe/blob/develop/src/sass/_nav.scss or directly to a new React Component. We need something like Navbar in bootstrap so that users of wireframe can quickly create a responsive navigation bar which blends in with other components.

@NMcDonough
Copy link

Do you still need contributions? If so, I'm interested.

@tjrathert
Copy link

I would like to help contribute if you are still looking for contributions.

@erickrod54
Copy link

Hello @agauniyal , is still open the issue ? i would like to work to do it :), can you assign it to me ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants