-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite: Move to custom tag based framework #23
Comments
Hey @agauniyal! |
@ajayns you're right, the tags must be prefixed with some term, but I think it should be shorter than
|
Wouldn't something like |
@ajayns yes |
Since this resource is not used in production, it's fine to use custom tags instead of CSS classes. We don't have to worry about SEO optimization since the output is not being used in production. +1 for using |
@agauniyal is this project and issue still active? I would like to help you. |
@antoschd sure! |
…m tags change class names to custom tag with syntax wf-{element} agauniyal#23
Is it ok to adopt React for this? I think that using |
What about the styles? Do you still want them to live as scss files or is it ok to have them always related to components? Another detail. Is the balloon dependency supposed to be working? Running locally for me it didn't. |
I think it's okay for them to live with components as long as they're only for those components. Balloon dependency works for me but I'm not on the latest develop commit. |
@ericorruption imho I don't think you should bring the insane overhead of React in just for a wireframe. |
Originally I wrote an in-house js script which generates simple html
<div>
tags with supplementary css classes to style them properly. This approach is good for short wireframes but doesn't scale with the complexity of the design. I'm thinking of moving to proper js framework that supports custom tags like -which could be individually styled and glued together. This will help in reducing the cognitive load from writing
index.html
which will be lot easier with custom tags, plus open more possibilities for this project.Open to suggestions.
The text was updated successfully, but these errors were encountered: