Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite: Move to custom tag based framework #23

Open
agauniyal opened this issue Jul 24, 2017 · 11 comments
Open

Rewrite: Move to custom tag based framework #23

agauniyal opened this issue Jul 24, 2017 · 11 comments
Milestone

Comments

@agauniyal
Copy link
Owner

Originally I wrote an in-house js script which generates simple html <div> tags with supplementary css classes to style them properly. This approach is good for short wireframes but doesn't scale with the complexity of the design. I'm thinking of moving to proper js framework that supports custom tags like -

<Header />
<HeroImage />
<Carousel />
<Footer />

which could be individually styled and glued together. This will help in reducing the cognitive load from writing index.html which will be lot easier with custom tags, plus open more possibilities for this project.

Open to suggestions.

@agauniyal agauniyal added this to the 1.0.0 milestone Jul 24, 2017
@ajayns
Copy link

ajayns commented Aug 26, 2017

Hey @agauniyal!
Firstly, shouldn't custom tags be named like <wireframe-header/> and so on?
Also, by using these tags would just changing the code in css from using classes to referring to the custom element name be good enough?

@agauniyal
Copy link
Owner Author

agauniyal commented Aug 26, 2017

@ajayns you're right, the tags must be prefixed with some term, but I think it should be shorter than wireframe so it's easier to type as well.

Also, by using these tags would just changing the code in css from using classes to referring to the custom element name be good enough?
I think yes. To expand onto this, I'm thinking a structure like custom components we see in frameworks like React.js or Vue.js (I'm personally biased towards vuejs ones) where they are composable and work fine with each other.

@ajayns
Copy link

ajayns commented Aug 26, 2017

Wouldn't something like wf- be a good idea? Also what do have in mind when you say composable? I'm pretty new to Vue.js @agauniyal

@agauniyal
Copy link
Owner Author

@ajayns yes wf- would be good here.

@crock
Copy link

crock commented Sep 20, 2017

Since this resource is not used in production, it's fine to use custom tags instead of CSS classes. We don't have to worry about SEO optimization since the output is not being used in production.

+1 for using wf-{element} format.

@antoschd
Copy link

antoschd commented Oct 4, 2017

@agauniyal is this project and issue still active? I would like to help you.

@agauniyal
Copy link
Owner Author

@antoschd sure!

antoschd added a commit to antoschd/wireframe that referenced this issue Oct 5, 2017
…m tags

change class names to custom tag with syntax wf-{element}

agauniyal#23
@ericorruption
Copy link

Is it ok to adopt React for this? I think that using create-react-app (very barebones, build system included) as a base and rebuilding on top of it would work nicely.

@ericorruption
Copy link

ericorruption commented Oct 20, 2017

What about the styles? Do you still want them to live as scss files or is it ok to have them always related to components?

Another detail. Is the balloon dependency supposed to be working? Running locally for me it didn't.

@agauniyal
Copy link
Owner Author

I think it's okay for them to live with components as long as they're only for those components. Balloon dependency works for me but I'm not on the latest develop commit.

@LoganDark
Copy link

LoganDark commented Dec 10, 2018

@ericorruption imho I don't think you should bring the insane overhead of React in just for a wireframe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants