Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send RPL_ISUPPORT (005) #119

Open
AeliusSaionji opened this issue Dec 9, 2022 · 1 comment
Open

Send RPL_ISUPPORT (005) #119

AeliusSaionji opened this issue Dec 9, 2022 · 1 comment

Comments

@AeliusSaionji
Copy link

AeliusSaionji commented Dec 9, 2022

Hello, I encountered an issue with the android irc client goguma, which adheres to what the developer refers to as the "defacto standard RFC": https://modern.ircdocs.horse/#connection-registration

Upon successful completion of the registration process, the server MUST send, in this order, the RPL_WELCOME (001), RPL_YOURHOST (002), RPL_CREATED (003), RPL_MYINFO (004), and at least one RPL_ISUPPORT (005) numeric to the client.

At least one 005 is required, and none are sent

irslackd/lib/irslackd.js

Lines 508 to 509 in 3e92616

this.ircd.write(ircUser.socket, 'irslackd', '001', [ ircUser.ircNick, 'irslackd' ]);
this.ircd.write(ircUser.socket, 'irslackd', '376', [ ircUser.ircNick, 'End of MOTD' ]);

If the server reply is missing CHANTYPES then, by the protocol, the client should expect that the server does not support channels.

And so, that's what happens in Goguma; all messages coming from ircd are received as private messages from each user, because it doesn't think the server supports channels.

I have no business telling irslackd to use this "defacto standard" over the formal RFC, I'm just a user caught in the middle of these two projects (irslackd and goguma).

Emersion is taking the stance that this is not goguma's bug, so I suppose it's up to irslackd how to proceed.

Thanks

@AeliusSaionji
Copy link
Author

referencing PR #120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant