Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hook property to control command output logging #680

Open
moorereason opened this issue Apr 1, 2024 · 0 comments
Open

Add hook property to control command output logging #680

moorereason opened this issue Apr 1, 2024 · 0 comments

Comments

@moorereason
Copy link
Collaborator

moorereason commented Apr 1, 2024

webhook currently logs command output on every request. When using include-command-output-in-response to send a complex response body, it may not be desirable to log the command output. See #676 (comment).

Proposal

Add a boolean disable-command-output-logging property. The default is false so that we're backward compatible.

This property would only affect "success" logging (as seen below). Errors would still be logged.

log.Printf("[%s] command output: %s\n", r.ID, out)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant