-
-
Notifications
You must be signed in to change notification settings - Fork 806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to stream command output #438
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've added ability to stream command output directly to a response. milolav@09642fb
Needed it to monitor manually invoked long running scripts. It is based on a code mentioned in this question https://stackoverflow.com/questions/19292113/not-buffered-http-responsewritter-in-golang
If script starts, a response will always be successful regardless of the exit code.
Would this addition be something in line with project goals?
One issue that I've noticed is when opening hook url in a browser, response gets delayed for a few seconds and I have no idea why. When opening with curl/wget response starts streaming immediately. Implementation from the stackoverflow ( https://play.golang.org/p/PpbPyXbtEs ) doesn't have this issue.
The text was updated successfully, but these errors were encountered: