Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request has been deprecated, should be switched to alternative module #1104

Open
mattiasrunge opened this issue Jun 23, 2020 · 5 comments
Open

Comments

@mattiasrunge
Copy link
Contributor

Thank you for a great module!
I get this warning from yarn when installing dependencies:
warning dropbox-v2-api > [email protected]: request has been deprecated, see request/request#3142

Since request is deprecated should it be switched to something else like https://www.npmjs.com/package/isomorphic-fetch

@adasq
Copy link
Owner

adasq commented Jun 23, 2020

You're correct. Will try to use node-fetch.
Thanks!

@boly38
Copy link

boly38 commented Nov 20, 2021

And request use json-schema in a pretty old version wich just declare a new moderate vulnerability:


edit: moderate issue fixed with npm update

@boly38
Copy link

boly38 commented Dec 7, 2022

please note that request rely on vulnerable qs version

  └─┬ [email protected]
    └── [email protected]
    
 qs  6.5.0 - 6.5.2
Severity: high
qs vulnerable to Prototype Pollution - https://github.com/advisories/GHSA-hrpp-h998-j3pp

@boly38
Copy link

boly38 commented Dec 10, 2022

Fixed with [email protected] : thanks 👍

@adasq
Copy link
Owner

adasq commented Dec 10, 2022

Hey @boly38 , sorry for the late response.
Correct. this one was addressed, though the request package is deprecated, which is a bit painful. Struggling with finding a time to migrate it :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants