Welcome to Acornima! #1
Replies: 2 comments 2 replies
-
Awesome work @adams85 ! I've sometimes played with the acorn porting idea, but due to huge work that would be, dismissed the idea. But you did it! I see that the structures are quite familiar so shouldn't have such steep learning curve. Acorn was definitely a great choice to port from - times were different when JS Esprima was the the only big player... You just had to do this just after Jint 3.0 was released with hard Esprima dependency 😉 It will be a nice exercise at some point to check how well Jint would take in a different parser implementation, but probably not in the near future as the exhausting 3.0 work has finally come to an end. I have no claims for copyrights, credits etc. Most of of the original work was done by Sebastien and then the other contributors - where I think you have done quite the workload too! Probably best check Sebastien for licensing, BSD-3 and MIT are both very permissive licenses, of course MIT probably is a bit better recognized as such. I'm not a lawyer... |
Beta Was this translation helpful? Give feedback.
-
I could create a PR for a basic NUKE build setup if you wish (including GitHub Actions), if you'd like? |
Beta Was this translation helpful? Give feedback.
-
Welcome!
@lahma, as the main maintainer of Jint and Esprima, I figured this newest project of mine may be of some interest to you. So I decided to show it to you first, before making it public. I'm very curious to hear your opinion.
Also, I borrowed some of your work that you did in Esprima (string matcher sourcegen, test262 runner, etc.). Even though a lot of that code was heavily refactored/improved, I'd like to ask if you are ok with this. Of course, I was going to "credit" you in some way, I'd just like to know if you have any formal requirement to do so.
Beta Was this translation helpful? Give feedback.
All reactions