Handle the "No timeout check" WARNings in the server log #1635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahbast
changed the title
Conformance check passed ✅No test result changes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1635 +/- ##
=======================================
Coverage 89.24% 89.24%
=======================================
Files 374 374
Lines 35683 35683
Branches 4027 4027
=======================================
+ Hits 31845 31846 +1
+ Misses 2538 2537 -1
Partials 1300 1300 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, QLever has a very clear log, except for the many "No timeout check ..." warnings, which look more like debug messages. This is now fixed by [TODO: explain how it is fixed].