-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Load progress percentage sometimes exceeding 100% #8
Conversation
…ntend to backend in a fixed time interval. Edited CMakeLists.txt to only capitalize the first character of CMAKE_BUILD_TYPE. Ensured semicolon consistency in script.js.
into one total progress, displays current stage to the user.
Declared _curRow as std::atomic in GeomCache.h
Nice, thank you!
Hm, I wasn't able to reproduce this. A single The general process is:
|
@Grandro Thanks for working on this. While you are at it, it would also be good to clarify in the progress bar which step does what. In particular, it should be clarified that the filling of the geomcache is a one-time-thing and does not have to be done for every query. More concretely, the first step could have a message as follows (center-aligned, it doesn't matter that the message is a bit longer, the subtitle can be in a smaller font though): Filling the geometry cache Similary, when the server has been restarted and the cached geometries are read from disk, there is currently nothing happening with the progress bar at all. There should be together with a message like this: Reading cached geometries from disk Concerning the 2/2 phase I have two comments:
steps that sometimes take time, but where currently no progress bar is shown on the screen. The fist |
@hannahbast Thanks for your concerns and detailed propositions. I was (and still am) busy with the GeoJSON support I wanted to implement, but I will get back to this as soon as that is done. |
added richer descriptions for the loading stages
This is now merged in master, I did it manually including some refactorings I have done. Thanks! |
Fixes #6
I couldn't reproduce the issue of the loading progress percentage exceeding 100% after the
double
change, but I added assert statements to catch if it still happens somehow.This holds true for the backend (and thus also for the frontend)
I have also declared
_curRow
to bestd::atomic
as suggested, in case aGeomCache
is used by several threads.Every thread calls
petrimaps::Server::handle
individually but I realized one single/loadstatus
request is handled by every thread (I only sent out one/loadstatus
request, placed a breakpoint where the request is handled in the server and saw every thread pause on that line) and would believe that this is not intended behaviour. InHttpServer::handle
getReq(connection)
returns the "same" request. What doesconnection
refer to here?