Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Creating a new payee as part of creating a new rule fails #4026

Open
1 task done
mullermn opened this issue Dec 23, 2024 · 4 comments
Open
1 task done

[Bug]: Creating a new payee as part of creating a new rule fails #4026

mullermn opened this issue Dec 23, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@mullermn
Copy link

Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

Having accidentally 'merged' a payee by applying a rule I was trying to recreate the original rule for future use. I type in the payee name for matching - this cannot automcomplete because the payee no longer exists. I selected 'Create new payee', but the payee that is created is not the one I requested, it is simply called 'new'.

How can we reproduce the issue?

Follow the workflow as described above, or shown here:
image
Create a rule for a payee that doesn't currently exist, and click 'Create Payee' when prompted

image
Observe that the payee that gets created has the wrong name

image
Validating that it's not just a graphical glitch from a separate view

image
Observe that the same thing has been happening previously

Where are you hosting Actual?

Pikapods

What browsers are you seeing the problem on?

Desktop App (Electron)

Operating System

Mac OSX

@mullermn mullermn added the bug Something isn't working label Dec 23, 2024
@pwinnski
Copy link

I tested this in v24.11.0 and again in v24.12.0 using the desktop app on MacOS, as well as in v24.11.0 using the web UI, and in all three cases the created Payee was what I requested.

image
image

I get the same (successful) results whether I create the payee by clicking or hitting enter.

You didn't say; what version are you using?

@mullermn
Copy link
Author

Whatever PikaPods is currently on - which is client 24.9.0 and server 24.12.0 today.

Having tested more today I can refine the profile a bit further though - the bug doesn't happen if I use a 'Payee is' rule, but it does if I choose 'Payee one of'.

@sveselinovic
Copy link

sveselinovic commented Dec 24, 2024

I can reproduce the bug on client version v24.12.0 locally, but only with "Payee one of", not with "Payee is", as described by the comment before.

This seems like a good first issue that I would like to tackle if nobody minds?

@pwinnski
Copy link

Ah, yes, "Payee one of" is broken, I missed that in the first screenshot!

@sveselinovic It seems the way to get "dibs" on an issue is to create a PR. Other than that, they don't assign issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants