Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenShift workflow doesn't work out of the box #2385

Open
jsoref opened this issue Apr 26, 2024 · 0 comments · May be fixed by #2386
Open

OpenShift workflow doesn't work out of the box #2385

jsoref opened this issue Apr 26, 2024 · 0 comments · May be fixed by #2386

Comments

@jsoref
Copy link
Contributor

jsoref commented Apr 26, 2024

#1564 added a workflow for Red Hat CodeReady Dependency Analytics, but it also broke the OpenShift workflow.

I used https://github.com/check-spelling-sandbox/starter-workflows-openshift-is-broken-1/actions/new?category=none&query=openshift and added the workflow.

You can see that it's broken:
https://github.com/check-spelling-sandbox/starter-workflows-openshift-is-broken-1/actions/runs/8841706172

image

The comment here does not match the code:

starter-workflows/deployments/openshift.yml

Lines 63 to 74 in 2435e57

# 🖊️ EDIT if you want to run vulnerability check on your project before deploying
# the application. Please uncomment the below CRDA scan job and configure to run it in
# your workflow. For details about CRDA action visit https://github.com/redhat-actions/crda/blob/main/README.md
#
# TODO: Make sure to add 'CRDA Scan' starter workflow from the 'Actions' tab.
# For guide on adding new starter workflow visit https://docs.github.com/en/github-ae@latest/actions/using-workflows/using-starter-workflows
crda-scan:
uses: ./.github/workflows/crda.yml
secrets:
CRDA_KEY: ${{ secrets.CRDA_KEY }}
# SNYK_TOKEN: ${{ secrets.SNYK_TOKEN }} # Either use SNYK_TOKEN or CRDA_KEY

@jsoref jsoref linked a pull request Apr 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(openshift): comment out dangling dependency jsoref/starter-workflows
1 participant
@jsoref