Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale label not removed after receiving comments/commit #1132

Open
2 of 5 tasks
joaopgrassi opened this issue Feb 2, 2024 · 4 comments
Open
2 of 5 tasks

Stale label not removed after receiving comments/commit #1132

joaopgrassi opened this issue Feb 2, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@joaopgrassi
Copy link

joaopgrassi commented Feb 2, 2024

Description:
I recently enabled the stable bot PR here. Yesterday I noticed a PR that clearly had updates, but the Stale label is still not removed from the PR. I looked into the PR and here is the timeline:

  • Stable label added: 2024-01-26 16:19 GMT+1
  • Comment from non-autor 2024-01-31 17:45 GMT+1
  • New commit: 2024-01-30 14:50 GMT+1

That is also consistent with what it is shown in the logs:

image

Action version:
2.312.0

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Repro steps:
Last job execution: https://github.com/open-telemetry/semantic-conventions/actions/runs/7750945678/job/21137993067
Affected PR: open-telemetry/semantic-conventions#627

Expected behavior:
The Stale label to be removed, since the PR received updates/activity:

  • A comment from a non-author in an existing thread/discussion
  • A new commit after the Stale label was added

Actual behavior:
The Stale label is there.

I'm not sure if I'm missing any configuration, but with the defaults it seems it should work:

If an update/comment occur on stale issues or pull requests, the stale label will be removed and the timer will restart

@joaopgrassi joaopgrassi added bug Something isn't working needs triage labels Feb 2, 2024
@joaopgrassi
Copy link
Author

Another example here open-telemetry/semantic-conventions#600

@HarithaVattikuti
Copy link

Hello @joaopgrassi
Thank you for creating this issue. We will investigate it and get back to you as soon as we have some feedback.

@rcomer
Copy link

rcomer commented Feb 19, 2024

Does the issue persist since you bumped the version?

@joaopgrassi
Copy link
Author

I have not seen it anymore, but it could be that I'm just not looking hard enough. I will try to keep an eye and see if anything gets closed unintentionally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants