Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Do not close PRs that have auto-merge activated #1096

Open
larsxschneider opened this issue Sep 25, 2023 · 1 comment
Open
Labels
feature request New feature or request to improve the current logic

Comments

@larsxschneider
Copy link

Description:
If a PR is enabled for auto-merge, then stale bot should never close the PR. Stale bot could add a comment to the PR saying that the PR is stuck in the auto-merge process.

Justification:
Auto-merge is a convenient feature to merge PRs without waiting for the completion of a long CI run. However, if a CI test fails unexpectedly (e.g. because of flakiness), then the PR would never turn green and consequently auto-merge would not perform the merge. After some time the stale action would close the PR.

However, I believe PRs that have auto-merge activated should never be closed automatically because there was already a serious intention to merge the PR.

/cc @leonor-loureiro @dkunkler

@larsxschneider larsxschneider added feature request New feature or request to improve the current logic needs triage labels Sep 25, 2023
@dsame
Copy link
Contributor

dsame commented Sep 26, 2023

Hello, @larsxschneider

Thank you for the input, we are going to start on the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

2 participants