Skip to content
This repository has been archived by the owner on Feb 9, 2021. It is now read-only.

Ruby 2.5.7 support #36

Closed
timolehto opened this issue Oct 15, 2019 · 16 comments
Closed

Ruby 2.5.7 support #36

timolehto opened this issue Oct 15, 2019 · 16 comments

Comments

@timolehto
Copy link

Updating our ruby version, but now with actions our CI is unable to use the latest 2.5.x Ruby to run tests etc.

https://www.ruby-lang.org/en/news/2019/10/01/ruby-2-5-7-released/

@shrmnk
Copy link

shrmnk commented Oct 28, 2019

Same here. Are there timelines from the time of release to the availability of ruby versions?

image

@shrmnk
Copy link

shrmnk commented Oct 30, 2019

So Github just announced that Actions will be GA on 13 November, anyone able to chime in on whether this will be available by then?
Can't imagine people moving their CI workflows into Actions then finding out month-old releases are not even available (edit: 3-month old releases aren't available either)

@dansteele
Copy link

I need ruby 2.6.5, and unless we can get support for that then unfortunately it's a no-go from the offset. I think this is going to be a pretty ubiquitous requirement for any serious app. 🙏

@clupprich
Copy link

Hej! I built https://github.com/clupprich/ruby-build-action over the weekend, which makes use of ruby-build to install exactly the version of Ruby you need.

While that sounds (and actually is) slow, you can use the actions/cache action to cache the Ruby installation in your workflows (which brings the time it takes to setup Ruby down to ~30 seconds).

Let me know if that works for you. Feeback/issue reports/contributions welcome!

@dansteele
Copy link

@clupprich That absolutely solved this for me, and I imagine it will do so for many others! Great job.
💯 💯 💯 💯 💯 💯

@leesmith
Copy link

leesmith commented Nov 7, 2019

Thanks @clupprich...that worked perfectly! Not sure how useful setup-ruby is when you can't specify the exact ruby version you need.

@MSP-Greg
Copy link
Contributor

MSP-Greg commented Nov 7, 2019

Not that everyone is testing on Windows, but I created MSP-Greg/actions-ruby, which installs current Ruby versions (along with ruby-head/master) and allows updating the gcc build tools/packages on Windows.

Ruby 2.3.3 is also available, but if used for extension gems, it compiles with the newer 'DevKit'...

@frankieroberto
Copy link

+1 for Ruby 2.5.7 support.

@fbjork
Copy link

fbjork commented Nov 15, 2019

+1

@frankieroberto
Copy link

I think this requires an update to the virtual environment, so I’ve requested it here: actions/runner-images#95

@u2606
Copy link

u2606 commented Dec 17, 2019

What are the currently supported Ruby versions? Our actions started failing today with a similar message, Version 2.5.5 not found.

Screen Shot 2019-12-17 at 3 10 33 PM

The support page linked by @konradpabjan in actions/setup-python#15 (comment) still says that Ruby 2.5.5 is supported.

@konradpabjan
Copy link

Ruby 2.5.5 should work. Just tested it out:
image

https://github.com/konradpabjan/Testing3/commit/9561e0ac0a4e7dcd4ab209aa0aacd3e4df02203c/checks?check_suite_id=365213462#step:4:4

Looking at the tools cache where the Ruby gets downloaded from, I still see version 2.5.5. It gets added here and automatically documented: https://github.com/actions/virtual-environments/blob/9786a9946a6db1a8d0c89948550753f9e01007b3/images/linux/scripts/installers/1804/hosted-tool-cache.sh#L39

If there are issues with the documented versions then actions/virtual-environments is the best place to report it.

@u2606
Copy link

u2606 commented Dec 18, 2019

2.5.5 is working for us again today. Thanks for testing it.

@bryanmacfarlane
Copy link
Member

Closing since 2.5.5 is working and there's already a tracking item in virtual-environments.

Note a related issue: #44

@frankieroberto
Copy link

2.5.7 is now available, and 2.5.5 has been removed.

@bryanmacfarlane
Copy link
Member

bryanmacfarlane commented Jan 31, 2020

See #49 - flushing out ideas

I have a prototype working locally where we download JIT from rvm if it's not already in the VM cache. I will have an experimental ref soon. The plan is to fall back ruby-build after that (which also has the benefits of self-hosted runners). @clupprich - I may pull inspiration from yours and/or you can have a look at my experimental branch. The ADR proposes using factored out caching logic (lib) so the consumer doesn't have to do the caching (probably just a bool option). Note that if self-hosted, it would only be slow the first build.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests