Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different label based on new/changed/removed #47

Open
ericcornelissen opened this issue Jan 20, 2020 · 5 comments · May be fixed by #79
Open

Different label based on new/changed/removed #47

ericcornelissen opened this issue Jan 20, 2020 · 5 comments · May be fixed by #79
Labels
feature request New feature or request to improve the current logic needs eyes

Comments

@ericcornelissen
Copy link
Contributor

ericcornelissen commented Jan 20, 2020 •
edited

I was wondering if it is either possible or desired to have a feature to: configure a label based on whether a file was newly created vs. a file was changed (vs. a file was removed).

In configuration I would imagine this could be written as follows:

"label on add":
  - on: added
  - example/**/*

"label on change":
  - on: modified
  - example/**/*

"label on remove":
  - on: removed
  - example/**/*

"label on multiple":
  - on:
    - added
    - modified
    - removed
  - example/**/*

"or if you don't care":
  - example/**/*

"and even": example/**/*

I have a working prototype at ericcornelissen/labeler (example PR added, example PR modified) which I could turn into a Pull Request for this project if there is more interest in this 😄

In practice I want to use this in simple-icons/simple-icons to label Pull Requests with either new icon or icon outdated based on whether a new icon was added or an icon was updated (respectively)
@ericcornelissen ericcornelissen mentioned this issue Jan 20, 2020
Merged
@SpencerKaiser
Copy link

I would love to see this issue implemented because I'd like to remove the changes requested label whenever a commit is pushed to a PR I've reviewed.

@ericcornelissen

This comment has been minimized.

Sign in to view
@dakale dakale mentioned this issue Apr 28, 2020
Merged
@ogtony
Copy link

ogtony commented Jun 18, 2020

@ericcornelissen Looks like #22 has been merged, can you make a pull for your implementation to this repo now?

@ericcornelissen ericcornelissen linked a pull request Jun 21, 2020 that will close this issue
Open
@ericcornelissen
Copy link
Contributor Author

@SpencerKaiser and @ogtony, I opened a PR for this feature 👍

@prakarshpandey
Copy link

Hey folks - Any updates on this ? I'd really like to use this functionality but the linked PR has not been merged yet.

@MaksimZhukov MaksimZhukov added the feature request New feature or request to improve the current logic label Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request to improve the current logic needs eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Assign label based on status (added, modified, removed) ericcornelissen/labeler
5 participants
@ericcornelissen @SpencerKaiser @prakarshpandey @ogtony @MaksimZhukov