Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch name checks ignored as top level key #743

Open
2 of 5 tasks
steverep opened this issue Jan 13, 2024 · 2 comments
Open
2 of 5 tasks

Branch name checks ignored as top level key #743

steverep opened this issue Jan 13, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@steverep
Copy link

steverep commented Jan 13, 2024

Description:
From the current documentation, I have no idea how this config is supposed to behave:

my-label:
  - changed-files:
    - ...
  - head-branch:
    - ...

When I read the docs, I expect it to behave as if both were under any, i.e. changed-files || head-branch. However it instead seems to completely ignore the head-branch config.

Action version:
5.0.0

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Repro steps:
See home-assistant/frontend#19321 where the action removed the "Dependencies" label despite the branch name matching. The debug log seems to indicate the branch name is not even checked:

https://github.com/home-assistant/frontend/actions/runs/7443800544/job/20458307412

Expected behavior:
Expect it to behave like any:

Actual behavior:
Ignores the head-branch check.

@steverep steverep added bug Something isn't working needs triage labels Jan 13, 2024
@steverep steverep changed the title Boolean logic with both changed files and branch names Branch name checks ignored as top level key Jan 14, 2024
@steverep
Copy link
Author

After examining the debug logs, it appears as if branch name checks are simply ignored as top level keys. I've adjusted the OP and issue title accordingly.

@HarithaVattikuti
Copy link
Contributor

Hello @steverep
Thank you for creating this issue. We will investigate it and get back to you as soon as we have some feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants