Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

Requesting toolchain version 1.70 installs 1.7.0 #230

Open
ydirson opened this issue Oct 2, 2023 · 2 comments
Open

Requesting toolchain version 1.70 installs 1.7.0 #230

ydirson opened this issue Oct 2, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@ydirson
Copy link

ydirson commented Oct 2, 2023

Description

After switching my action from install toolchain 1.66 to 1.70, what I actually get is 1.7.0 (and surprisingly he build fails).
As a workaround requesting 1.70.0 works, but it's obviously not good, in case a 1.70.1 comes out.

Workflow code

xcp-ng/xcp-metrics@5175694

    steps:
    - uses: actions/checkout@v3
    - uses: actions-rs/toolchain@v1
      with:
-        toolchain: 1.66
+        toolchain: 1.70
        override: true

Action output

https://github.com/xcp-ng/xcp-metrics/actions/runs/6377565635/job/17306468710

Run actions-rs/toolchain@v1
/home/runner/.cargo/bin/rustup show
Default host: x86_64-unknown-linux-gnu
rustup home:  /home/runner/.rustup

stable-x86_64-unknown-linux-gnu (default)
rustc 1.72.1 (d5c2e9c34 2023-09-13)
/home/runner/.cargo/bin/rustup toolchain install 1.7
info: syncing channel updates for '1.7.0-x86_64-unknown-linux-gnu'
@ydirson ydirson added the bug Something isn't working label Oct 2, 2023
ydirson added a commit to xcp-ng/xcp-metrics that referenced this issue Oct 2, 2023
More dependencies keep getting released with a 1.70 requirement,
targetting 1.66 is not realistic any more.

Because of actions-rs/toolchain#230, specify the requirement as
"1.70.0" to avoid getting old 1.7.0 instead.

Drop artificial dependency pinning (reverts
ddb06f0).
@lambda-fairy
Copy link

This is a feature of YAML, not a bug. 1.70 is parsed as the number 1.7.

The workaround is to wrap the string in quotes:

-        toolchain: 1.70
+        toolchain: '1.70'

@ydirson
Copy link
Author

ydirson commented Oct 9, 2023

Arf, implicit stringification in a bad place. Should probably show examples with version numbers, not just stable and nightly, and put a bold note there.

(note I've started moving on to dtolnay/rut-toolchain as a maintained successor of this project)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Development

No branches or pull requests

2 participants