Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

failed to remove label if it's not exist #269

Open
dirablue opened this issue Aug 10, 2021 · 4 comments
Open

failed to remove label if it's not exist #269

dirablue opened this issue Aug 10, 2021 · 4 comments
Labels
bug Something isn't working

Comments

@dirablue
Copy link

dirablue commented Aug 10, 2021

What happened

when I tried to remove all labels set with "labels" options, the error occurred for removing 'stg' label, and 'prd' label which exists was not removed.

  • these are labels status before run
    dev: exists
    stg: NOT exists
    prd: exists
labels: |
  dev
  stg
  prd

in this case,
'dev' label is removed
but 'prd' label is not removed because the error of removing 'stg' label.

Run actions-ecosystem/action-remove-labels@v1
Error: HttpError: Label does not exist

What you expected to happen

run a process successfully even if an error occur of removing labels

@dirablue dirablue added the bug Something isn't working label Aug 10, 2021
@micnncim
Copy link
Member

You encountered the issue even if fail_on_error is set false?

https://github.com/actions-ecosystem/action-remove-labels#inputs

@dirablue
Copy link
Author

dirablue commented Aug 13, 2021

@micnncim
hi, yes it occurred even if I set fail_on_error = false

@egmacke
Copy link

egmacke commented Oct 11, 2021

I'm also running into this issue. While it's not a breaking change (it reports an error, but doesn't fail the workflow step) it does record an error against the workflow run.

I'm using this to remove a build-failed label at the start of the workflow run (it's added at the end if needed) but obviously a lot of the time this label doesn't already exist and getting an error reported is irritating.

I'm happy to attempt a PR to fix this unless it's already being worked on by anyone?

@litaocdl
Copy link

I met this error too, for a workaround I am looking for a github action to check if label is exists before removing, but it is great if this issue could be fixed.

LeonMontealegre added a commit to OpenCircuits/OpenCircuits that referenced this issue Sep 3, 2022
This is because of actions-ecosystem/action-remove-labels#269, so definitely needs to be fixed in the future once this issue is fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants