Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpcs-security-audit may be abandoned #12

Closed
danepowell opened this issue Aug 17, 2020 · 1 comment · Fixed by #13
Closed

phpcs-security-audit may be abandoned #12

danepowell opened this issue Aug 17, 2020 · 1 comment · Fixed by #13

Comments

@danepowell
Copy link
Collaborator

danepowell commented Aug 17, 2020

FloeDesignTechnologies/phpcs-security-audit#78 (comment)

acquia/coding-standards-php depends on phpcs-security-audit, but according to the maintainer's comment above it may be abandoned.

If it's critical to acquia/coding-standards-php, can the team consider supporting the maintainer or that project?

If it's not critical, can we drop the dependency?

Apart from the long-term stability/security considerations of using an abandoned project, there's the immediate impact of these warnings that appear every time you do a composer install:

Deprecation Notice: Class PHPCS_SecurityAudit\Sniffs\Drupal8\CVE20132110Sniff located in ./vendor/pheromone/phpcs-security-audit/Security/Sniffs/CVE/20132110Sniff.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0.

@TravisCarden
Copy link
Contributor

Thanks, @danepowell. It's by no means critical, and it probably doesn't warrant the challenges arising from lack of maintenance at this point. I'll remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants