Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI-1192: Symfony 6.3.4 breaks checklists #1620

Open
danepowell opened this issue Nov 1, 2023 · 0 comments
Open

CLI-1192: Symfony 6.3.4 breaks checklists #1620

danepowell opened this issue Nov 1, 2023 · 0 comments

Comments

@danepowell
Copy link
Contributor

danepowell commented Nov 1, 2023

Checklists are supposed to look like this:

Screen.Recording.2023-11-01.at.12.44.49.PM.mov

Upgrading to 6.3.4 breaks them:

Screen.Recording.2023-11-01.at.12.44.13.PM.mov

The culprit is this PR: symfony/symfony#51378

When the progress bar advances and ConsoleSectionOutput->doWrite('my message\n', false) is called, the patch changes this to $message = 'my message' and $newline = true. You'd think this would be equivalent, but apparently it's not, as it results in too many lines being cleared, erasing the checklist and previous console output.

Our checklist and spinner classes are here: https://github.com/acquia/cli/tree/main/src/Output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant