Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In "destroy" method, if user has two or more ace-diff elements, the "removeEventHandlers" only remove the last "onResize" handler. #64

Open
Weiee opened this issue Oct 12, 2019 · 0 comments · May be fixed by #113
Open

In "destroy" method, if user has two or more ace-diff elements, the "removeEventHandlers" only remove the last "onResize" handler. #64

Weiee opened this issue Oct 12, 2019 · 0 comments · May be fixed by #113

Comments

@Weiee
Copy link

Weiee commented Oct 12, 2019 •
edited

the "addEventHandlers" function is not in AceDiff scope, when call window.removeEventListener, 'onResize' eventhandler is actually hold by the "addEventHandlers" scope.
image

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@Weiee