-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor vault.py #90
Labels
Comments
@mzfr I was thinking about the same issue. I think it is a great idea, it will also be more easier to configure Travis later on. |
Hi, found this in KWOC. Would like to try to refactor it. But need some context on how to group functions (like which functions can be grouped into a module and then be imported into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, we have around 1200 lines of code in a single file which is probably not a good practice. Also, this will increase since we are going to continue to add more functions. So it would be good if we can move the functions out of the
vault.py
file and only keep it as an entry point and maybe perform basic checks on ip/url.To call other functions we can have maybe a
util
directory where we can keep all the existing functions. This will increase the number of imports or number of files but it will definitely help us to keep everything clean in vault.pyThe text was updated successfully, but these errors were encountered: