Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide some .env file for secrets #40

Open
choosen opened this issue Mar 31, 2021 · 4 comments
Open

Provide some .env file for secrets #40

choosen opened this issue Mar 31, 2021 · 4 comments

Comments

@choosen
Copy link

choosen commented Mar 31, 2021

We should encourage people to store credentials outside the codebase.
Currently there are i.e. github credentials stored as plain text in config/github

@abhaynikam
Copy link
Owner

@choosen I am sorry the issue is not quite clear to me. Could you share some more details? Is this a new feature request or problem with an existing generators? 😊

@choosen
Copy link
Author

choosen commented Mar 31, 2021

@abhaynikam https://youtu.be/9vaK9nDMbU8?t=584 devise config should encourage to set up it through environment
variable

So this is more about existing generator (devise oauth), but that practice should be applied anywhere

@choosen
Copy link
Author

choosen commented Mar 31, 2021

@coolprobn
Copy link
Contributor

We have added generators for dotenv and Rails also already has Credentials now.

I have not looked into the implementation yet for Oauths but if we are using plain text then we definitely need to migrate them off to use ENV or Rails.credentials

Please feel free to take this on if you want. Examples for such cases are in new generators:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants