Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor selectors #238

Open
remmeier opened this issue Sep 23, 2017 · 0 comments
Open

refactor selectors #238

remmeier opened this issue Sep 23, 2017 · 0 comments

Comments

@remmeier
Copy link
Collaborator

many of the current selectors in NgrxJsonApiSelectors could be pure functions. There is no need to wrap those in a service (because the store location is constant since ngrx4).
remmeier added a commit that referenced this issue Sep 23, 2017
@remmeier
introduced pur getNgrxJsonApiStore selector #238
77c1267
remmeier added a commit that referenced this issue Sep 23, 2017
@remmeier
updated exports #238
59e0fdb 
- config token exported to access ngrx configuration
- all selectors exported
remmeier added a commit that referenced this issue Sep 24, 2017
@remmeier
introduced pur getNgrxJsonApiStore selector #238
d137d5b
remmeier added a commit that referenced this issue Sep 24, 2017
@remmeier
updated exports #238
aa9cb0b 
- config token exported to access ngrx configuration
- all selectors exported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@remmeier