New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Items are not always added to a SkipList #137
Comments
Thanks for supporting the development of C# Algorithms with your first issue! We look forward to handling it. |
Gutsonok
added a commit
to Gutsonok/C-Sharp-Algorithms
that referenced
this issue
Aug 5, 2020
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When attempting to add an item to the SkipList, it is not always added. This seems to be caused by the fact that the _getNextLevel() method may return 0, in which case the for loop on line 138 that adds elements to the SkipList is not entered because lvl is 0.
To Reproduce
It is a bit difficult to reproduce, since a SkipList is a probabilistic data structure, so the behaviour will not be the same every time it is used. However, the following should work:
Expected behavior
I expect that after adding a number to a list of integers, the list will contain that number
Environmnet:
Additional context
If the Random object in the SkipList is initialized with seed 123, the first call to Add will not insert the element
The text was updated successfully, but these errors were encountered: