Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommend to use imageio.v3 instead of imageio #1894

Open
xunmeibuyue opened this issue Jan 12, 2023 · 3 comments · May be fixed by #1956
Open

Recommend to use imageio.v3 instead of imageio #1894

xunmeibuyue opened this issue Jan 12, 2023 · 3 comments · May be fixed by #1956
Labels
dependencies For issues and PRs concerning project dependencies. See lib- prefix for individual dependencies. design-decisions Discussion of ideas, suggestions, questions relevant to (re)design decision-making process. feature-request Request for a new feature or additional functionality. lib-imageio Issues pertaining to dependency imageio.

Comments

@xunmeibuyue
Copy link

xunmeibuyue commented Jan 12, 2023 •
edited

I would like to recommend to use imageio.v3 instead of imageio when just import imread from imageio, specifically in such two position:

moviepy/moviepy/video/VideoClip.py

Line 14 in 858bb81

from imageio import imread, imsave

moviepy/moviepy/video/io/ImageSequenceClip.py

Line 8 in 0751d07

from imageio import imread

This is because imageio.v3.imread support more image format than imageio.imread such as .webp. And if necessary I would like to submit a PR.
@xunmeibuyue xunmeibuyue added the feature-request Request for a new feature or additional functionality. label Jan 12, 2023
@keikoro keikoro added lib-imageio Issues pertaining to dependency imageio. dependencies For issues and PRs concerning project dependencies. See lib- prefix for individual dependencies. design-decisions Discussion of ideas, suggestions, questions relevant to (re)design decision-making process. labels Feb 6, 2023
@mgaitan
Copy link
Collaborator

mgaitan commented Apr 22, 2023

+1 to this. If you still can submit a PR I could review quickly and move it forward. Thanks.

@xunmeibuyue
Copy link
Author

Of course! I have submitted a PR at #1955 (comment). Thanks.

@xunmeibuyue
Copy link
Author

A new PR has been submitted at #1956. Thanks.

@mgaitan mgaitan linked a pull request Apr 27, 2023 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies For issues and PRs concerning project dependencies. See lib- prefix for individual dependencies. design-decisions Discussion of ideas, suggestions, questions relevant to (re)design decision-making process. feature-request Request for a new feature or additional functionality. lib-imageio Issues pertaining to dependency imageio.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use imageio.v3 when read or write images xunmeibuyue/moviepy
3 participants
@keikoro @mgaitan @xunmeibuyue