Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add a 3-dot menu button when displaying report #464

Open
NivLipetz opened this issue Oct 7, 2020 · 6 comments
Open

UI: Add a 3-dot menu button when displaying report #464

NivLipetz opened this issue Oct 7, 2020 · 6 comments
Labels
good first issue Good for newcomers UI

Comments

@NivLipetz
Copy link
Member

Is your feature request related to a problem? Please describe.
The report now has a Set as benchmark button, I would like to add more functionality on the display report window but this will look too crowded.

Describe the solution you'd like
Add a menu button on the top right of the display report window. The following should be true:

  1. When clicking on the button the "Set as benchmark" should appear in the menu
  2. Hover should change color to the same color hint that other buttons in Predator change to when hovered over.

Should look something like this:
image
Preferably the 3 dots should be smaller than in the image (and with the color specified in additional context below).

Additional context
Please use the following icon as a button: https://fontawesome.com/icons/ellipsis-v?style=solid with smallest size
With Predator's color scheme: #0d47ff

@JatinAgrawal94
Copy link

I would like to work on this issue could you assgin it to me?

@Zooz Zooz deleted a comment from kra-tosss Oct 7, 2020
@Zooz Zooz deleted a comment from ajay-droid Oct 7, 2020
@Zooz Zooz deleted a comment from ajay-droid Oct 7, 2020
@NivLipetz
Copy link
Member Author

Hi @JatinAgrawal94 that would be great! We are available on our Slack workspace if you have any questions feel free!

@NivLipetz
Copy link
Member Author

Hi @JatinAgrawal94 , have you had a chance to start this issue yet? Can I help in any way?

@JatinAgrawal94
Copy link

Hi @NivLipetz , I am still working on this issue , it will be resolved in a short time.

@NivLipetz
Copy link
Member Author

Hi @JatinAgrawal94 how's it going? Need anything from us?

@abiramcodes
Copy link

abiramcodes commented Dec 8, 2023

Hello @NivLipetz , @enudler

I tried to set up the project in my local, while doing the npm run setup-local-env -> I was asked to do the node setup-env.js in the terminal. I tried installing it. but asked for the specific version of node and npm.

Steps I followed for the after that :

  1. Installed the specific version ( 12.x.x ) of node . Then It asked for 14.x.x.
  2. Installed the version of 14.x.x of node. Then it asked for 16.x.x
  3. Installed the version of 16.x.x of node. then it is asking for the version 12.x.x again.

Could you please help me setup the environment ?

I am able to see the UI screen by doing npm start. but I am not able to navigate the screen that is mentioned in the issue. I guess I need to setup the setup-env to access the report screen as it is mentioned in the issue.

I would like to contribute to this issue if it is still open and assign to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers UI
Projects
None yet
Development

No branches or pull requests

4 participants