Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer to peer code review #25

Open
yasinabdmahmood opened this issue Jul 29, 2022 · 5 comments
Open

Peer to peer code review #25

yasinabdmahmood opened this issue Jul 29, 2022 · 5 comments

Comments

@yasinabdmahmood
Copy link

No description provided.

@benardop
Copy link

  • @ZikaZaki , good work on this project 👍
  • I would suggest you change the variables you have declared using the 'var' keyword to use 'const' keyword to define your variable. That will help you resolve the issue of variable names conflicts in the file

@ZikaZaki
Copy link
Owner

Thanks @benardop for the feedback. It will be considered and implemented.

@yasinabdmahmood
Copy link
Author

Great job on the pop up window design it looks just like a Figma template , but there are some parts of your code that could be improved for example you can create event listeners inside a javascript file instead of declaring them inside an HTML file it will help you avoid linter error of defining function but not using it

@ZikaZaki
Copy link
Owner

Thanks @yasinabdmahmood for the amazing feedback. It will be considered and implemented.

@GraceAbike
Copy link
Collaborator

You have done a good job, but remain little to get it done, there are some errors, and the JavaScript code is more than 100

ALittleBitSaturdayNightLiveGIF (2)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants