Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refined useEffectOnce to solely act as an alias for React.useEffect(effect, [||]). #600

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refined useEffectOnce to solely act as an alias for React.useEffect(effect, [||]). #600

wants to merge 2 commits into from

Conversation

lukaszkrzywizna
Copy link
Contributor

Resolves #595

@lukaszkrzywizna
Correct the implementation of the dispose function invocation within …
cff1676 
…the `useEffectOnce` hook.
@lukaszkrzywizna
Refined useEffectOnce to solely act as an alias for `React.useEffec…
159fc2c 
…t(effect, [||])`, removing logic dependent on double effect invocation in `React.StrictMode` which led to bugs in `IDisposable` overloads.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarification and Potential Improvement on PR #480 useEffectOnce behavior
1 participant
@lukaszkrzywizna