Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter: Blur doesn't work #565

Open
lukaszkrzywizna opened this issue Mar 10, 2023 · 2 comments
Open

Filter: Blur doesn't work #565

lukaszkrzywizna opened this issue Mar 10, 2023 · 2 comments

Comments

@lukaszkrzywizna
Copy link
Contributor

According to documentation https://developer.mozilla.org/en-US/docs/Web/CSS/filter-function/blur
Filter's blur accepts three units: px, rem, or none (for 0).

Feliz's Style module expects to put:

  • int for a percentage value from 0 to 100
  • double as a floating number from 0 to 1

Using any of those doesn't work. However, using custom style works:

style.custom("filter", "blur(2px)")

I guess those functions should be replaced with a new one using an ICssUnit or something similar.

@Zaid-Ajaj
Copy link
Owner

Hi @lukaszkrzywizna, thanks for filing the issue. I will see if I can fix it sometime this week. Otherwise if you want to take a stab at it, please feel free to do so 😄

@stmax82
Copy link

stmax82 commented Apr 17, 2024

I just ran into the same issue and fixed it but I'm too dumb to figure out how to run the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants