Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchronous credential repository support #219

Open
jroper opened this issue Aug 17, 2022 · 1 comment
Open

Asynchronous credential repository support #219

jroper opened this issue Aug 17, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@jroper
Copy link

jroper commented Aug 17, 2022

The current credential repository interface requires that all the invoked methods are handled synchronously. This doesn't work if you're using an asynchronous database driver in an asynchronous web framework, such as on Play Framework, Akka HTTP, etc. It would be ideal if the java-webauthn-server core library could provide asynchronous alternatives, allowing database lookups to return CompletionStage etc.

@emlun
Copy link
Member

emlun commented Aug 22, 2022

Hi! This is a good idea, but it'll likely take some pretty significant refactoring to support. I'd been thinking the stateless design of the library would hopefully play nice with asynchronous architectures, but you're right that the nature of the "callbacks" in CredentialRepository throw a wrench in that.

I think async support shouldn't be too hard to implement, the main question is whether it can be done without breaking backwards compatibility. I can't give you a time frame just yet, but I'll try to look into the feasibility of it soon.

@emlun emlun added the enhancement New feature or request label Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants