Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yotpo shouldn't override CSP configuration #268

Open
denis-zyk opened this issue Feb 23, 2021 · 1 comment
Open

Yotpo shouldn't override CSP configuration #268

denis-zyk opened this issue Feb 23, 2021 · 1 comment

Comments

@denis-zyk
Copy link

<csp>
<mode>
<storefront>
<report_only>1</report_only>
</storefront>
<admin>
<report_only>1</report_only>
</admin>
</mode>
</csp>

Yotpo shouldn't override Magento's CSP configuration and thus weakening the security.
Otherwise, all CSP implementations (e.g. in custom module) would have to include Yotpo_Yotpo in module's loading sequence dependency if the latter has been installed.

@pinchas13
Copy link

Thank you @denis-zyk for your response here.
Currently working on a fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants