Remove unused files in Cron directory #236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves the following composer warning: Deprecation Notice: Class Yotpo\Yotpo\Cron\UpdateMetadataJob located in ./vendor/yotpo/magento2-module-yotpo-reviews/Cron/UpdateMetadata.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:201
lgreenboim
reviewed
Apr 27, 2020
There was a problem hiding this comment.
Thank you very match @fredden! Your PR code was inserted to the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #228
This resolves the following composer warning:
While renaming the file was my initial suggestion, I can't see anywhere these files are used, so removing makes sense. In
crontab.xmlthe "Jobs" models are called directly. These files seem to be left over from b3b4d0e and not removed in c49f574 (both of which are part of #176).