Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Composer Deprecation notice; file doesn't comply with autoloading standard #228

Open
MellenIO opened this issue Mar 11, 2020 · 1 comment
Open

Composer Deprecation notice; file doesn't comply with autoloading standard #228

MellenIO opened this issue Mar 11, 2020 · 1 comment
Assignees
@sharp80 @pniel-cohen
Labels
enhancement priority: low

Comments

@MellenIO
Copy link

When running composer dumpautoload in a Magento 2 project, I get the following warning from Composer:

Deprecation Notice: Class Yotpo\Yotpo\Cron\UpdateMetadataJob located in ./vendor/yotpo/magento2-module-yotpo-reviews/Cron/UpdateMetadata.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0.

The file Cron/UpdateMetadata.php does not comply with PSR-4 autoloading. Seeing the specification:

The terminating class name corresponds to a file name ending in .php. The file name MUST match the case of the terminating class name.

The file Cron/UpdateMetadata.php needs to be renamed to UpdateMetadataJob.php rather than UpdateMetadata.php.
@yotpaul
Copy link

yotpaul commented Apr 1, 2020

Hey @MellenIO I'm going to open an internal issue for this and let you know once it's resolved.

pniel-cohen pushed a commit that referenced this issue Apr 7, 2020
Changed cron class UpdateMetadata to UpdateMetadataJob to align with …
dfc6c5a 
…it's class name. Should solve GH issue #228
@pniel-cohen pniel-cohen mentioned this issue Apr 7, 2020
Merged
lgreenboim pushed a commit that referenced this issue Apr 23, 2020
@lgreenboim
Changed cron class UpdateMetadata to UpdateMetadataJob to align with …
cb352ce 
…it's class name. Should solve GH issue #228
lgreenboim pushed a commit that referenced this issue Apr 23, 2020
@lgreenboim
Changed cron class UpdateMetadata to UpdateMetadataJob to align with …
e113fb4 
…it's class name. Should solve GH issue #228
lgreenboim pushed a commit that referenced this issue Apr 23, 2020
@lgreenboim
Changed cron class UpdateMetadata to UpdateMetadataJob to align with …
6f54bd4 
…it's class name. Should solve GH issue #228
lgreenboim pushed a commit that referenced this issue Apr 23, 2020
@lgreenboim
Changed cron class UpdateMetadata to UpdateMetadataJob to align with …
a3d4eca 
…it's class name. Should solve GH issue #228
lgreenboim pushed a commit that referenced this issue Apr 23, 2020
@lgreenboim
Changed cron class UpdateMetadata to UpdateMetadataJob to align with …
9252978 
…it's class name. Should solve GH issue #228
@fredden fredden mentioned this issue Apr 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sharp80 sharp80

@pniel-cohen pniel-cohen

Labels
enhancement priority: low
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unused files in Cron directory fredden/yotpo-magento2-module-yotpo-reviews
4 participants
@sharp80 @MellenIO @pniel-cohen @yotpaul