Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest version of react-reconciler #83

Open
wearhere opened this issue Oct 4, 2018 · 1 comment
Open

Update to latest version of react-reconciler #83

wearhere opened this issue Oct 4, 2018 · 1 comment

Comments

@wearhere
Copy link

wearhere commented Oct 4, 2018

Even though the README says that this library will work with React's latest v16.x.x, it does not seem that we can use the new lifecycles and context APIs introduced in React v16.3. For example:

  • if I implement the new lifecycle APIs on components, they're not called
  • if I try to mount a component <Consumer>{value => /* renderable */}</Consumer> in the tree, I get an error Invariant Violation: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: object.
  • I get an error trying to use React.createRef

I think this is because this library is using an outdated version of react-reconciler. That's where the latter invariant violation originates, and if I look up that invariant in the latest version of react-reconciler, there is logic about the new context API that does not exist in the version used by this library.

@Yomguithereal
Copy link
Owner

You are right. Unfortunately I don’t have much time right now. I will of course review and probably accept a PR fixing this issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants