New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest version of React: injectEmptyComponent undefined #50
Comments
Yes, it would be nice to support v15. Do you think this is the only thing preventing the renderer from working with v15? The only thing a bit tedious would also be to detect the version of React so that the code may work with 14 or 15 independently. |
@Yomguithereal Apparently v15 has changed internals quite a lot. _rootNodeID is a globally increased integer now for instance, which pretty much breaks how you do id operations. |
@Yomguithereal This project looks really good, I was just about to start building a dashboard using it when I came across this issue. The last comment was in May and I'm using react 0.15 on all my projects now, do we have a plan for supporting react 0.15. I'm happy to help out, do we have a list of issues that need to be resolved? |
For that, one would need to go and perform some archaeology within React's code to see what changed concerning the injection of the renderers. |
I know the docs say to use react 0.14.0 but it also says ">="
Is there plans to upgrade to a new version of react?
The part that seems broken for me is that:
ReactInjection.EmptyComponent
no longer has functioninjectEmptyComponent
as it now takes a factory function:The text was updated successfully, but these errors were encountered: