From aaa5081d7f74e69056843ca2ca7cced5e47d3ee4 Mon Sep 17 00:00:00 2001
From: jrfnl <jrfnl@users.noreply.github.com>
Date: Sat, 21 Dec 2024 15:57:17 +0100
Subject: [PATCH] GH Actions: add actionlint job

This job checks the GH Actions workflows against syntax errors and other problems.

Includes minor fixes to pre-existing workflows to allow the build to pass.
---
 .github/workflows/basics.yml    | 4 ++++
 .github/workflows/quicktest.yml | 4 ++--
 .github/workflows/test.yml      | 8 ++++----
 3 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/basics.yml b/.github/workflows/basics.yml
index 46a9837..da532d8 100644
--- a/.github/workflows/basics.yml
+++ b/.github/workflows/basics.yml
@@ -19,6 +19,10 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
+  actionlint:
+    name: 'Lint GH Action workflows'
+    uses: Yoast/.github/.github/workflows/reusable-actionlint.yml@main
+
   checkcs:
     name: 'Basic CS and QA checks'
     runs-on: ubuntu-latest
diff --git a/.github/workflows/quicktest.yml b/.github/workflows/quicktest.yml
index 9a19e8e..6a7d9ab 100644
--- a/.github/workflows/quicktest.yml
+++ b/.github/workflows/quicktest.yml
@@ -44,9 +44,9 @@ jobs:
         id: set_ini
         run: |
           if [ "${{ matrix.cs_dependencies }}" != "dev" ]; then
-            echo 'PHP_INI=error_reporting=E_ALL & ~E_DEPRECATED, display_errors=On' >> $GITHUB_OUTPUT
+            echo 'PHP_INI=error_reporting=E_ALL & ~E_DEPRECATED, display_errors=On' >> "$GITHUB_OUTPUT"
           else
-            echo 'PHP_INI=error_reporting=-1, display_errors=On' >> $GITHUB_OUTPUT
+            echo 'PHP_INI=error_reporting=-1, display_errors=On' >> "$GITHUB_OUTPUT"
           fi
 
       - name: Install PHP
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 5da5325..ac455e1 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -72,9 +72,9 @@ jobs:
         id: set_ini
         run: |
           if [ "${{ matrix.cs_dependencies }}" != "dev" ]; then
-            echo 'PHP_INI=error_reporting=E_ALL & ~E_DEPRECATED, display_errors=On' >> $GITHUB_OUTPUT
+            echo 'PHP_INI=error_reporting=E_ALL & ~E_DEPRECATED, display_errors=On' >> "$GITHUB_OUTPUT"
           else
-            echo 'PHP_INI=error_reporting=-1, display_errors=On' >> $GITHUB_OUTPUT
+            echo 'PHP_INI=error_reporting=-1, display_errors=On' >> "$GITHUB_OUTPUT"
           fi
 
       - name: Install PHP
@@ -157,9 +157,9 @@ jobs:
         id: set_ini
         run: |
           if [ "${{ matrix.cs_dependencies }}" != "dev" ]; then
-            echo 'PHP_INI=error_reporting=E_ALL & ~E_DEPRECATED, display_errors=On' >> $GITHUB_OUTPUT
+            echo 'PHP_INI=error_reporting=E_ALL & ~E_DEPRECATED, display_errors=On' >> "$GITHUB_OUTPUT"
           else
-            echo 'PHP_INI=error_reporting=-1, display_errors=On' >> $GITHUB_OUTPUT
+            echo 'PHP_INI=error_reporting=-1, display_errors=On' >> "$GITHUB_OUTPUT"
           fi
 
       - name: Install PHP