Undefined index: orderby

[kkmuffme]

• I've read and understood the contribution guidelines.
• I've searched for any related issues and avoided creating a duplicate issue.

Please give us a description of what happened

Undefined index: orderby
as reported in #21422

To Reproduce

• use phpstan or psalm
  or
• take a look at the code in https://github.com/Yoast/wordpress-seo/blob/trunk/admin/class-meta-columns.php#L458
  or
• open https://foo.com/wp-admin/edit.php?post_type=shop_order with woocommerce installed and possibly a filter/query that runs without orderby

Expected results

no error

Actual results

PHP notice

Technical info

• If relevant, which editor is affected (or editors):

• Block Editor
• Gutenberg Editor
• Elementor Editor
• Classic Editor
• Other: WooCommerce order page and other pages that don't specify orderby

Used versions

• PHP version: 8.2.x
• WordPress version: 6.5.3
• WordPress Theme: issue is in wp-admin unrelated to theme
• Yoast SEO version: 22.8

[josevarghese]

Hi @kkmuffme

Thanks for getting back to us.

I cannot replicate this on the new WooCommerce and Yoast SEO plugin installation. So, can you please navigate to the WooCommerce > Settings > Advanced > Features > and let us know what kind of Order data storage is selected? Are you using the legacy version of order data storage or the recommended one (which is High-performance order storage)?

We look forward to hearing from you and are happy to help you.

[kkmuffme]

The site's using HPOS. However there are lots of plugins, that might filter something there and cause that.

Just validate with isset instead of assuming orderby key exists.