Context

• We want to make sure that our cleanup cron is not running and not scheduled when indexables are disabled.

Summary

This PR can be summarized in the following changelog entry:

• Disabled an unneeded cleanup cronjob when indexables are disabled.

Relevant technical choices:

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Note: Wherever add_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' ); is mentioned, it can also mean that you are on a non-production site instead (aka, have the WP_ENVIRONMENT_TYPE constant indicate a staging or local or development site).

• Make sure you have the crontrol plugin enabled. And make sure there is currently no cron with the name wpseo_start_cleanup_indexables. If there is remove it by hovering over the cron and clicking delete. Refresh the page to make sure it has happend.
• Also make sure you have the CPT ui plugin enabled with a taxonomy and post type created. Add one post and one taxonomy item, and run the SEOO

Activation of the plugin for the second time.

• Have the add_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' ); filter active somewhere on your site.
• Disable Free and re-enable free. The wpseo_start_cleanup_indexables should not be present in the cron overview.
• Remove the filter and repeat the steps. Now the wpseo_start_cleanup_indexables cron should be visible.

Disable attachment indexables

• Have the add_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' ); filter active somewhere on your site.
• Make sure you remove the previously made wpseo_start_cleanup_indexables cron.
• Go to /admin.php?page=wpseo_page_settings#/media-pages and enable media pages. Disable it again and amke sure the cron is not shown in the overview.
• Disable the filter and repeat. The cron should now show up.

Disable author archives

• Have the add_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' ); filter active somewhere on your site.
• Make sure you remove the previously made wpseo_start_cleanup_indexables cron.
• Go to /admin.php?page=wpseo_page_settings#/author-archives and enable author archives. Disable it again and make sure the cron is not shown in the overview.
• Disable the filter and repeat. The cron should now show up.

Remove a taxonomy

• Have the add_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' ); filter active somewhere on your site.
• Make sure you remove the previously made wpseo_start_cleanup_indexables cron.
• Go to custom post type ui en remove your taxonomy.
• Make sure the cron is not there
• Disable the filter and repeat. Create a new taxonomy and remove this after creating it and make sure the cron now does show up.

Remove a post type

• Have the add_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' ); filter active somewhere on your site.
• Make sure you remove the previously made wpseo_start_cleanup_indexables cron.
• Go to custom post type ui en remove your post type.
• Make sure the cron is not there.
• Disable the filter and repeat. Create a new post type and remove this after creating it and make sure the cron now does show up.

Remove post from author

• Enable author archives
• Make sure you have an author with exactly 1 post.
• Have the add_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' ); filter active somewhere on your site.
• Make sure you remove the previously made wpseo_start_cleanup_indexables cron.
• Remove the post you added to the author.
  Make sure the cron is not there.
• Disable the filter and repeat. Create or add a new post to the author and remove that post. The cron should now show up.

Run the cleanup

To test if the cleanup will not run with the filter enabled we will try to remove author archive indexables that are no longer needed.

• Without the filter enabled. Make sure author archives are enabled and visit the author archive page of and author with 1 or more posts.
• Verify that you have an author indexable.
• Now disable author archives. You should have the wpseo_start_cleanup_indexables cron.
• Have the add_filter( 'Yoast\WP\SEO\should_index_indexables', '__return_false' ); filter active somewhere on your site.
• Click run now on the cron. And make sure the author indexable is still there.
• Also make sure the cron has unscheduled itself.
• Now repeat the steps without the filter and make sure the indexables are actually removed.

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes #