Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file size next to file name under the progress bar #1471

Closed
YamatoSecurity opened this issue Nov 5, 2024 · 2 comments · Fixed by #1500
Closed

Add file size next to file name under the progress bar #1471

YamatoSecurity opened this issue Nov 5, 2024 · 2 comments · Fixed by #1500
Assignees
Labels
enhancement New feature or request Priority:Low
Milestone

Comments

@YamatoSecurity
Copy link
Collaborator

Sometimes it takes quite a while to process a file because it is very big and we cannot give completely accurate progress bar progress as the .evtx file does not tell the amount of records. Some people may think that Hayabusa has hung so I want to make it easier to understand that it is taking time because the file size is big.

Before:

[00:00:29] 576 / 1,237 ⠤ [==================>                     ] 47%

"../hayabusa-samples/Microsoft-Windows-Sysmon%4Operational.evtx"

After:

[00:00:29] 576 / 1,237 ⠤ [==================>                     ] 47%

"../hayabusa-samples/Microsoft-Windows-Sysmon%4Operational.evtx (50.2 GB)"

We should use the same format for what we do when calculating Total file size. Ex: 17.3 KB, 14.5 MB, 12.2 GB, etc...

@YamatoSecurity YamatoSecurity added enhancement New feature or request Priority:Low labels Nov 5, 2024
@YamatoSecurity
Copy link
Collaborator Author

@fukusuket Could I ask you to do this one? Maybe it is very easy for you.

@fukusuket
Copy link
Collaborator

@YamatoSecurity
Thank you for mention! Yes, I would love to implement it!💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Priority:Low
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants