-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
systemctl import-environment without specifying desired variables is deprecated #254
Comments
Hey! I cargo culted that line from other projects. I'm not sure if it's actually needed. Could try removing it (and the dbus one below) and see if everything still works? The actually important variables like WAYLAND_DISPLAY are imported by the niri binary itself. |
I believe we'd still want the WAYLAND_DISPLAY and XDG_... variables to end up in D-Bus and systemd after niri is ready and before too many (or any at all) other new processes have started I had a related conversation with the COSMIC folks about this, but that solution doesn't map cleanly to the infrastructure we have here: pop-os/cosmic-session#31 |
Yeah, the niri binary takes care of that. |
Howdie, thanks so much for sharing this project! <3
I noticed a deprecation message pop up briefly during
niri
's launch, and I tracked it down to this: systemd/systemd#18137And we call
systemctl --user import-environment
without specific variable names here:niri/resources/niri-session
Line 24 in 40cec34
The thing is, I'm not sure when this will stop working on the
systemctl
side, seeing as it's been deprecated for yearsAnd I'm not even sure what I'd recommend going forward
niri
process itself (and thus every child process it launches), just not in the user service managerAnother aspect of the current behaviour is that variables from the virtual console environment end up in my user service manager environment, like TERM=linux and PWD which are often unhelpful/confusing once I'm in a GUI desktop environment (but I can probably find workarounds for my own stuff)
Anyhow, this has probably not been super helpful, but I thought I'd log it, just in case anyone else notices the deprecation message :)
The text was updated successfully, but these errors were encountered: