Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Add JXL support and/or full FFmpeg support #24

Open
octopushugger opened this issue Jul 2, 2022 · 3 comments
Open
Assignees

Comments

@octopushugger
Copy link

I use JXL a lot so having thumbs would be great. FFmpeg appears to support JXL so adding full FFmpeg support instead of adding JXL individually might be a better way to futureproof Icaros.

Another idea you might want to consider is to allow for user provided FFmpeg libraries. Again, this could potentially futureproof Icaros so that in the case of you being busy or whenever you finally abandon the project then users could replace the library themselves to add new format support.

@Xanashi
Copy link
Owner

Xanashi commented Jul 11, 2022

I am looking into JXL for Icaros at the moment, but there is a chance I'll go bit of a different direction than FFmpeg. I haven't decided yet.
As always I try to keep FFmpeg fairly vanilla for Icaros, to keep the releases small and easier to debug.

In the meantime you may want to take a look at the following projects here on Github, to get thumbnails for you JXL files:

https://github.com/mirillis/jpegxl-wic
https://github.com/saschanaz/jxl-winthumb

Loading FFmpeg dynamically is a very daunting task, with lots of potential complications including security/malware, debugging, instability and so on. It's just not viable.
With that said, if I ever need to stop my development of Icaros, I'll be sure to open source it, so other interested parties can continue the work, if they like.

@Xanashi Xanashi self-assigned this Oct 22, 2022
@Quisquose
Copy link

Another vote here for adding JXL support (it's a great format).

Despite the focus of Icaros being video and audio files (and not image files) I would still love to see an exception made for JXL.

Most other image file types already have a variety of thumbnailing solutions that work on different versions of Windows, but JXL only has a couple of options (those linked above) and none of them work on Windows 7 (whereas Icaros works flawlessly on Windows 7).

* (by the way, I personally would not have a problem if JXL thumbnailing was provided as a separate shell extension rather than part of Icaros, if Xanashi thought that this would be a 'neater' or more 'orderly' solution).

@neoOpus
Copy link

neoOpus commented Aug 30, 2023

For the moment, this is the best alternative is JPEG XL Thumbnails ShellEx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants